Support comma separated list values in --exclude argument #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppham-nv
force-pushed
the
exclude-comma-support
branch
from
77144a9
to
9c20805
Compare
|
Travis CI infrastructure issue since it cannot pull https://app.travis-ci.com/github/pypa/auditwheel/jobs/626999921#L20476 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had to add a separate --exclude flag for each lib:
auditwheel repair test.whl --exclude=liba.so --exclude=libx.soThis PR allows passing in multiple libs as a comma separated list:
auditwheel repair test.whl --exclude=liba.so,libx.soNote: There's also a minor change to the
test_build_wheel_with_binary_executablewhich is unrelated to this change but the CI automatic test is failing probably due to some changes in manylinux image where the calculated python path no longer is "python" but it's "python3.9", "python3.10" etc so we have to append the version accordingly.